Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host User Creation group reconciliation removes groups from users not managed by Teleport #45536

Closed
rosstimothy opened this issue Aug 15, 2024 · 1 comment
Assignees
Labels
bug c-mzz Internal Customer Reference c-pm Internal Customer Reference regression server-access

Comments

@rosstimothy
Copy link
Contributor

rosstimothy commented Aug 15, 2024

After #41178 was resolved, Teleport will attempt to reconcile groups for users when host user creation is enabled. However, as pointed out by @strideynet in #45411 (comment):

Additionally, I think there's another problematic behavior here where we are updating groups for users regardless of whether or not they were created by Teleport. Surely we only want to manage the groups of users that were created by Teleport?

Introduced by #41919

@pschisa pschisa added the c-mzz Internal Customer Reference label Aug 15, 2024
@pnrao1983 pnrao1983 added the c-pm Internal Customer Reference label Aug 16, 2024
@rosstimothy
Copy link
Contributor Author

rosstimothy commented Aug 19, 2024

Going forward Teleport should only reconcile groups if the user can be identified as managed by Teleport. Presently this is only possible for users created when using DROP or INSECURE DROP mode because they get added to a teleport-system group. Users created in KEEP mode are not added to any groups, so Teleport cannot determine if an existing user is managed by Teleport or not.

To fix this issue Teleport should start adding users created in KEEP mode to a teleport-managed group. Any users previously created by Teleport have three options for migrating to being managed by Teleport:

  1. update host_groups in the users role to include teleport-managed
  2. manually delete the local user from the host
  3. manually add the local user to the teleport-managed group

This also applies to static host users which will exist in the near future. These users are going to be added to the teleport-static group so they will be identifiable out of the gate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug c-mzz Internal Customer Reference c-pm Internal Customer Reference regression server-access
Projects
None yet
Development

No branches or pull requests

4 participants