Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support automountServiceAccountToken in teleport-cluster helm charts #47594

Closed
rohithrrao opened this issue Oct 15, 2024 · 2 comments · Fixed by #47680
Closed

Support automountServiceAccountToken in teleport-cluster helm charts #47594

rohithrrao opened this issue Oct 15, 2024 · 2 comments · Fixed by #47680
Labels
feature-request Used for new features in Teleport, improvements to current should be #enhancements

Comments

@rohithrrao
Copy link

What would you like Teleport to do?
teleport-custer helm charts should support support setting the value of automountServiceAccountToken

What problem does this solve?
Disabling ServiceAccount token mounts is a common security best practice and also a requirement for some production environments.

If a workaround exists, please include it.
Create your own ServiceAccount with automountServiceAccountToken set to false. But it increases the maintenance burden on Helm chart users.

@rohithrrao rohithrrao added the feature-request Used for new features in Teleport, improvements to current should be #enhancements label Oct 15, 2024
@webvictim
Copy link
Contributor

Hey @rohithrrao, @hugoShaka and I talked about this and we decided not to expose the automountServiceAccountToken value for users to configure, but instead to automatically set it to false on newer Kubernetes distributions which support the use of projected service account tokens.

This is more in line with Teleport's overall stance of "security by default" and should just automatically follow best practice when supported by the underlying Kubernetes cluster.

Thank you for the suggestion!

@hugoShaka
Copy link
Contributor

Please note that this will not change anything for the pods as every deployment from the chart already disables automatic SA creds mount when projected volumes are supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Used for new features in Teleport, improvements to current should be #enhancements
Projects
None yet
3 participants