Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the "client_credentials" grant type to the default admin client #244

Merged
merged 1 commit into from
Jun 8, 2018
Merged

Add the "client_credentials" grant type to the default admin client #244

merged 1 commit into from
Jun 8, 2018

Conversation

pletessier
Copy link

@tcompiegne
Copy link
Member

Hi @pletessier, don't you think we should also update existing admin client ?

Your code only apply if the admin client doesn't exist.

@pletessier
Copy link
Author

Hi @tcompiegne ,
From my point of view, setting the grant_type at init is enough. I just need that to be able to create an access_token the first time. If user changes are made after, I suppose that Gravitee shouldn't overwrite them. It would be confusing.

@tcompiegne
Copy link
Member

All right, according to our contributing guide, can you sign the CLA, and I will accept your PR.

Contributor License Agreement

Please sign our Contributor License Agreement (CLA) and send it to contact@graviteesource.com. For any code changes to be accepted, the CLA must be signed.

Thanks.
Regards.

@tcompiegne tcompiegne added this to the 1.6.3 milestone Jun 8, 2018
@tcompiegne
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants