fix: a11y issues fixes #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kyzyl-ool
requested review from
NikitaCG,
niktverd,
Marginy605,
Raubzeug,
ogonkov,
KirillDyachkovskiy,
artemipanchuk,
amje,
ValeraS and
korvin89
as code owners
|
Preview is ready. |
amje
requested changes
Apr 26, 2024
| @@ -109,6 +121,9 @@ export function DefinitionList({ | |||
| text={copyText} | |||
| className={b('copy-button')} | |||
| view={iconInside ? 'raised' : 'flat-secondary'} | |||
| extraProps={{ | |||
| 'aria-label': i18n('label_copy'), | |||
There was a problem hiding this comment.
ClipboardButton already has aria text
There was a problem hiding this comment.
really, thank you
| @@ -103,6 +105,7 @@ export const SharePopover = (props: SharePopoverProps) => { | |||
| renderCopy, | |||
| children, | |||
| onClick, | |||
| controlAriaLabel, | |||
There was a problem hiding this comment.
buttonAriaLabel, we already have button* props
Kyzyl-ool
force-pushed
the
feat/fixing-some-a11y-issues
branch
from
ac30179 to
121e3a4
Compare
amje
approved these changes
May 13, 2024
ogonkov
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.