fix: add aria-label for DefinitionList help popover #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kyzyl-ool
requested review from
Raubzeug,
amje,
ValeraS and
korvin89
as code owners
|
Preview is ready. |
amje
reviewed
Jul 10, 2024
package.json
Outdated
| @@ -123,4 +123,4 @@ | |||
| "prettier --write" | |||
| ] | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Your editor is removing last new line, please disable this)
There was a problem hiding this comment.
fixed my vscode settings)
Raubzeug
requested changes
Jul 10, 2024
| <HelpPopover | ||
| className={popoverClassName} | ||
| placement={['bottom', 'top']} | ||
| {...note} |
There was a problem hiding this comment.
let's do like
const {buttonProps, ...rest} = note
...
07d9529 to
d9eb9af
Compare
Raubzeug
approved these changes
Jul 10, 2024
amje
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.