feat(PlaceholderContainer): add placeholder container component #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
Marginy605
force-pushed
the
placeholder-container
branch
from
20c17e7 to
a46a953
Compare
amje
requested changes
Apr 14, 2023
amje
requested changes
Apr 19, 2023
| } | ||
|
|
||
| &__description { | ||
| margin-top: 10px; |
| private renderContent() { | ||
| const {html, contentSize, contentClassName} = this.props; | ||
|
|
||
| const content = html ? ( |
There was a problem hiding this comment.
Let's use renderContent function prop instead of html
Marginy605
force-pushed
the
placeholder-container
branch
from
654439e to
5152296
Compare
amje
requested changes
Apr 28, 2023
CODEOWNERS
Outdated
| @@ -1 +1,2 @@ | |||
| /src/components/FormRow @ogonkov | |||
| /src/components/PlaceholderContainer @marginy | |||
| type PlaceholderContainerImageSettingsProps = { | ||
| url: string; | ||
| alt?: string; | ||
| size?: number; |
There was a problem hiding this comment.
Not sure if we need this prop, we already have image constraints. In fact, image from url can be rectangle shape or smaller size than image contanier
There was a problem hiding this comment.
That's a good point. I removed this prop.
| } | ||
|
|
||
| return ( | ||
| <div className={b('action')}> |
There was a problem hiding this comment.
Maybe rename it to plural form, actions?
|
|
||
| import './PlaceholderContainerAction.scss'; | ||
|
|
||
| const b = block('placeholder-container-action'); |
There was a problem hiding this comment.
This should be the same block placeholder-container and action is an element of the block
There was a problem hiding this comment.
fixed
I've also refactored structure of types and constants a little bit
Marginy605
force-pushed
the
placeholder-container
branch
from
8697ca3 to
951e2d7
Compare
amje
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.