Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add item params to edit menu item handler #22

Merged
merged 3 commits into from
Oct 27, 2022

Conversation

goshander
Copy link
Member

@goshander goshander commented Oct 27, 2022

for more custom edit menu handler need context or item prams property. I find it difficult to choose the best solution to pass to menu handler the whole context or just the item params object. What do you think is the best thing to do?

@goshander goshander requested a review from jhoncool October 27, 2022 09:55
@goshander goshander marked this pull request as ready for review October 27, 2022 09:55
@jhoncool
Copy link
Collaborator

@goshander the best way is to add widget parameters as the second argument.

@goshander goshander merged commit f220322 into main Oct 27, 2022
@goshander goshander deleted the edit-menu-item-params branch October 27, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants