feat(TextInput)!: separate into 2 components TextInput & TextArea #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korvin89
requested review from
jhoncool,
amje,
Volodomor and
ValeraS
as code owners
|
Preview is ready. |
amje
requested changes
Jun 26, 2023
src/components/controls/utility-components/ClearButton/ClearButton.scss
Outdated
Show resolved
Hide resolved
src/components/controls/utility-components/ClearButton/ClearButton.tsx
Outdated
Show resolved
Hide resolved
amje
requested review from
ogonkov,
sofiushko,
krozhkov,
DarkGenius,
Avol-V,
mfyodorov,
kseniya57,
DaffPunks,
goshander,
axtk,
vrozaev and
Marginy605
as code owners
korvin89
force-pushed
the
separate-inputs-v5
branch
from
963c0a5 to
f3d824b
Compare
amje
requested changes
Jun 29, 2023
src/components/List/types.ts
Outdated
| @@ -25,7 +25,7 @@ export type ListProps<T = unknown> = QAProps & { | |||
| sortable?: boolean; | |||
| deactivateOnLeave?: boolean; | |||
| sortHandleAlign?: ListSortHandleAlign; | |||
| size?: TextInputSize; | |||
| size?: InputControlSize; | |||
There was a problem hiding this comment.
If it uses only TextInput, then it should use that specific type
| @@ -1,6 +1,6 @@ | |||
| import userEvent from '@testing-library/user-event'; | |||
|
|
|||
| import type {TextInputSize} from '../../TextInput'; | |||
| import type {InputControlSize} from '../../controls'; | |||
| width: 100%; | ||
| font-weight: normal; | ||
| font-family: var(--yc-text-body-font-family); | ||
| color: var(--yc-color-text-primary); |
korvin89
force-pushed
the
separate-inputs-v5
branch
from
1cb2610 to
e41e75d
Compare
amje
approved these changes
Jun 30, 2023
amje
added a commit
that referenced
this pull request
Jul 10, 2023
Co-authored-by: Andrey Morozov <amje@yandex-team.ru>
amje
added a commit
that referenced
this pull request
Jul 14, 2023
Co-authored-by: Andrey Morozov <amje@yandex-team.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #561
Closes #630