add line rendering for tourism=attraction

[HolgerJeromin]

http://www.openstreetmap.org/way/256157138
had a slim area around with tourism=attraction to get a nice pink label. But the fence is the attraction, so i moved the POI data to the fence.
It would be nice to have again a label (with offset like a footway?) to this attraction.

[polarbearing]

A label should be no problem, the question remains how a linear feature should be treated once tourism=attraction is rendered as an area #1257, which might be an outline as discussed in #1624.

[HolgerJeromin]

I would propose to have no own line for a attraction, as i cannot think about a usecase where a linear attraction has no main key (like highway (?), fence, wall,...).
This is different to an closed line.

[jojo4u]

I detailed some problems with tourism=attraction here: http://wiki.openstreetmap.org/wiki/Talk:Tag:tourism%3Dattraction

[matkoniecz]

Possible display method: https://cloud.githubusercontent.com/assets/899988/10133846/0d5e8180-65e1-11e5-98e9-90def5b5acaa.png

I would propose to have no own line for a attraction, as i cannot think about a usecase where a linear attraction has no main key (like highway (?), fence, wall,...).

Rendering names for barriers would be problematic. People love to tag linear and area objects on the same OSM element leading to things like [barrier=wall; landuse=cemetery; name=*].

[kocio-pl]

We have somewhat similar problem with buildings - people add different amenities and their name is rendered as if it was a building name, so we have a bit of confusion between two objects on the same OSM way.

[matkoniecz]

See also #971 for problems with rendering unable to handle putting linear and area object in one OSM element.

[dieterdreist]

sent from a phone

Am 28.09.2015 um 13:27 schrieb Mateusz Konieczny notifications@github.com:

Rendering names for barriers would be problematic. People love to tag linear and area objects on the same OSM element leading to things like [barrier=wall; landuse=cemetery; name=*].

I believe this common practice will sooner or later stop, because it really brings a lot of ambiguity into mapping when several objects (like a cemetery and a fence) are represented by the same object in osm. The rendering shouldn't encourage this style of mapping by working around the problems and guessing what might have been meant.

A better approach in your example would be to use an attribute on the area rather than a linear feature tag, e.g. "walled=yes" or "fenced=yes". Or use different objects like a way for the barrier and a multipoligon relation (defined by this way) for the area.

[dieterdreist]

sent from a phone

Am 28.09.2015 um 13:36 schrieb kocio-pl notifications@github.com:

We have somewhat similar problem with buildings - people add different amenities and their name is rendered like it is a building name, so we have a bit of confusion between two objects on the same OSM way.

yes, it's the same problem and should be discouraged as well.

[matkoniecz]

And the second version, with rendering names for all kinds of barriers.

For combined barrier and landuse label display ended unchanged with the current version of the code.

[HolgerJeromin]

Thanks for trying names on barriers. Considering attraction for text color would be nice. So you can see it is an attraction and not only a named fence.

[matkoniecz]

On the other hand most of other labels for other object is not rendered differently after adding tourism=attraction and named barriers are anyway rare.

[HolgerJeromin]

I am fine with both. :-)
Probably you are right. Pink text could be strange, because of the dy. So it is not clear the attraction is the barrier. Pink barrier is not good either.

[HolgerJeromin]

Are there other line attractions?
I can think about unusual cases only:
A long bench for example.

Street with attraction is probably good to ignore.

[matkoniecz]

Currently there is exactly one bench tagged as way, with tourism=attraction - http://www.openstreetmap.org/way/313487068 (see http://overpass-turbo.eu/s/bKm).

[matkoniecz]

And benches on ways are completely not rendered, so rendering only names makes little sense. Lack of rendering of benches tagged as ways may or may not be worth reporting.

I think that merging #1885 should fix problem reported here.

[HolgerJeromin]

Yes, your pr would be a nice solution for my issue. Thanks

[matkoniecz]

Related to "Add area render for tourism=attraction" #1257

I think that we should not render it as a line. Even rendering name is a bit dubious, but rendering it as a line would further encourage using it for ragging for renderer.

Rendering tourism=attraction labels is barely acceptable as there are many, many different small objects where some instances of them are for some reason interesting. Rendering all of them as icons is not going to happen.

I will not go as far as to propose dropping rendering of tourism=attraction labels but adding line rendering would further encourage tagging for renderer. I think that it outweights negatives.

I plan on closing this issue as declined without implementing line rendering for tourism=attraction.