Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add leisure=fitness_centre icon/text #2375

Closed
boothym opened this issue Sep 26, 2016 · 8 comments · Fixed by #2891
Closed

Add leisure=fitness_centre icon/text #2375

boothym opened this issue Sep 26, 2016 · 8 comments · Fixed by #2891

Comments

@boothym
Copy link
Contributor

boothym commented Sep 26, 2016

Currently leisure=fitness_centre is not rendered (neither is fitness_station as mentioned in #1870).

Even without an icon at the very least the name should be displayed, just like sports_centre.

At the moment any properly tagged gym is invisible which doesn't help encourage people to tag it correctly.

@boothym boothym changed the title Render leisure=fitness_centre icon/text Add leisure=fitness_centre icon/text Sep 26, 2016
@micahcochran
Copy link
Contributor

There are now 4789 instance of this tag.

How about this as an icon?
weight lifter 2

@boothym
Copy link
Contributor Author

boothym commented Nov 2, 2016

I notice in the maps.me app it is rendered with weights: https://github.com/mapsme/omim/blob/e646b270bd68d0c27adac5ed712682cf1500b68c/data/styles/clear/style-night/symbols/gym-l.svg - I wonder if they would allow it to be used?

@boothym
Copy link
Contributor Author

boothym commented Nov 3, 2016

@gravitystorm @math1985 @pnorman @matkoniecz

Any chance we could get leisure=fitness_centre rendered the same way as a sports_centre node, so that the name is visible? Right now there are many correctly tagged gyms etc. which aren't rendered on the map. An icon can be added or text fine-tuned later.

@boothym
Copy link
Contributor Author

boothym commented Jan 8, 2017

@kocio-pl while we wait for an icon, any chance of the fitness_centre being rendered exactly like sports_centre, so that the text is visible?

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jan 9, 2017

I do few other things here, so if somebody creates the code, that would be great. Are you willing to do that?

@boothym
Copy link
Contributor Author

boothym commented Jan 9, 2017

If all that's required is adding fitness centre beside sports centre in project.mml then I will submit a PR with that change soon.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jan 9, 2017

Look for sports centre also in MSS files - project.mml is more or less a database part, styling is defined in MSS.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 9, 2017

See #1870 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants