Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show big lake names earlier #2847

Closed
kocio-pl opened this issue Sep 17, 2017 · 6 comments
Closed

Show big lake names earlier #2847

kocio-pl opened this issue Sep 17, 2017 · 6 comments

Comments

@kocio-pl
Copy link
Collaborator

I think big lake name labels should be visible on z7+ (start of the midzoom) - z10+ is much too late:

http://www.openstreetmap.org/#map=10/43.8325/-77.6795

@kocio-pl kocio-pl added the water label Sep 17, 2017
@kocio-pl kocio-pl added this to the Bugs and improvements milestone Sep 17, 2017
@kocio-pl
Copy link
Collaborator Author

It makes sense for me to start even from z6, because it's a small, limited change for low zoom and big lakes start showing with a proper size to have labels.

@kocio-pl
Copy link
Collaborator Author

For biggest lakes (filtered only water=lake tags to make database import time manageable) it seems to be working great:

z6
Great Lakes
qmhcdcpp

Caspian Sea + Aral Sea
bxfqq5de

However there are some strange label placement issues, though I have only changed zoom from z10+ to z6+ in my draft code:

  1. Sometimes it's different with filtered data than on current map:
    Ladoga Lake
    t2wv_8ls

  2. Sometimes it's already there, it just would start showing earlier:
    Lake Yessey
    ts6nmna2

  3. Sometimes it's hard to say yet, because I couldn't find a label on the current map:
    Lake Victoria
    ctl_vbre

Any ideas what could it be?

@kocio-pl
Copy link
Collaborator Author

At least it looks like dataset was responsible for inconsistency - full data from Ladoga Lake area give the labels placed as expected:

z6
kfqxdbxv

@kocio-pl
Copy link
Collaborator Author

This is somewhat related to #1604, because starting zoom level for labels depends (to some extent) on starting zoom level for showing lakes.

@kocio-pl
Copy link
Collaborator Author

Just a note: the problem with label placement is probably described in #1465.

@kocio-pl
Copy link
Collaborator Author

Resolved by #2873.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant