Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for leisure=firepit #2910

Closed
Tomasz-W opened this issue Oct 28, 2017 · 7 comments
Closed

Add icon for leisure=firepit #2910

Tomasz-W opened this issue Oct 28, 2017 · 7 comments

Comments

@Tomasz-W
Copy link

W have 8,5k of leisure=firepit, but is not rendered.
https://taginfo.openstreetmap.org/tags/leisure=firepit

Examples:
http://www.openstreetmap.org/way/525604639
https://www.openstreetmap.org/way/527840126
https://www.openstreetmap.org/node/5128204779

I think firepits may be important information for tourists, and should be rendered.

My icon proposal:
leisure firepit2
14x14:
leisure firepit

@kocio-pl kocio-pl added this to the New features milestone Oct 28, 2017
@kocio-pl
Copy link
Collaborator

Sounds reasonable to me. My questions:

  1. What should be the color?
  2. Is it enough to distinguish from firestation icon?
  3. Could you prepare also code and test rendering?

@Tomasz-W
Copy link
Author

@kocio-pl

  1. Brown, I think. Then it will fit other tourism elements
  2. For me, it's ok (different fire shape and "x" part), but I'd like to hear another users opinion.
  3. Unfortunely no, I have no skills in that things.

BTW. I found that tourism=picnic_site and leisure=picnic_table are rendering the same.
Example: http://www.openstreetmap.org/#map=19/52.40365/16.85518
I think it's bad and it could make misunderstandings. Picnic sites are non-physical feature (it's rather area description), and picnic tables are physical things. Mayby just changing picnic sites icon colour to green (the same as playgrounds or minigolf) would be good? What do you think?

@kocio-pl
Copy link
Collaborator

I agree with you, picnic site icon and label should be leisure green.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Nov 8, 2017

Could you publish SVG code of a firepit icon?

@Tomasz-W
Copy link
Author

Tomasz-W commented Nov 8, 2017

@geesona
Copy link

geesona commented Dec 30, 2017

I do like the firepit icon but do not think it suitable for an electric BBQ. Perhaps the cross could be changed for an electric charging sign, or lightning flash?

@sommerluk
Copy link
Collaborator

I do like the firepit icon but do not think it suitable for an electric BBQ.

That’s exactly what we want. leisure=firepit is defined as place for open fire, not for electric BBQ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants