Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.5.0 #2919

Closed
kocio-pl opened this issue Nov 2, 2017 · 10 comments
Closed

Release v4.5.0 #2919

kocio-pl opened this issue Nov 2, 2017 · 10 comments
Labels

Comments

@kocio-pl
Copy link
Collaborator

kocio-pl commented Nov 2, 2017

I guess we should release v4.5.0 with our more or less regular, time-based schedule, so about 17.11. Is there anything that should be done before release, aside from updating preview image (because of #2903)?

@matthijsmelissen
Copy link
Collaborator

Do we want to get #2934 in?

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Nov 12, 2017

I'd like to. This case seems to be strong for me on its merits and I don't expect to hear something more than different "I don't like it" variants, but given how popular it is, I prefer to make it about a week before deciding.

@boothym
Copy link
Contributor

boothym commented Nov 12, 2017

#2891 can surely be included as well?

@kocio-pl
Copy link
Collaborator Author

I think so. I just try to wait with merging until a month has passed if there are no formal reviews.

@matthijsmelissen
Copy link
Collaborator

I think we could do a release.

@kocio-pl
Copy link
Collaborator Author

What about parkings? It's not merged yet. Was this a wrong button clicked or you want to wait with it?

@matthijsmelissen
Copy link
Collaborator

Was this a wrong button clicked

Yes. Merged now.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Nov 14, 2017

Great! It's the second reason to update preview image then. 😄

You can make the release if you want. If not, I will probably do it on Friday, because I believe it's better to start re-rendering when the servers are less busy.

@matthijsmelissen
Copy link
Collaborator

I won't have time until the weekend either.

(Of course there's also no guarantee operations will be available at a particular time to roll out the release.)

@kocio-pl
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants