Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render *_name=* or *:name=* if there is only one and no name=* #2935

Closed
Penegal opened this issue Nov 8, 2017 · 8 comments
Closed

Render *_name=* or *:name=* if there is only one and no name=* #2935

Penegal opened this issue Nov 8, 2017 · 8 comments
Labels

Comments

@Penegal
Copy link
Contributor

Penegal commented Nov 8, 2017

Hello, there.

The title says it all: when there is no name=*, but only one among *_name=* and *:name=*, it should be rendered instead. That would encourage contributors to fill these fields instead of name=*, when the value is supposed to not be in name=* but in another one. One example I have in mind is substation or transformer names: to highlight the fact that the name belongs to the substation or the transformer and not to the building containing it or the pole supporting it, it should be mapped as substation:name=* or transformer:name=*, but naive contributors could think that, as the name is not rendered, it should be put in name=* in order to be rendered. Rendering the way I suggested could remove this assumption, and ultimately improve modelling.

Regards.

@matkoniecz
Copy link
Contributor

matkoniecz commented Nov 8, 2017

That is not a good place to invent a new tagging.

substation:name tag at this moment is used 0 times worldwide - see https://taginfo.openstreetmap.org/keys/substation:name

transformer:name is used 1 time according to https://taginfo.openstreetmap.org/keys/transformer:name#overview

Please, propose, discuss and promote new tags on tagging mailing list and/or OSM Wiki and/or local forums.

@dieterdreist
Copy link

dieterdreist commented Nov 8, 2017 via email

@SomeoneElseOSM
Copy link
Contributor

SomeoneElseOSM commented Nov 8, 2017

Ignoring substations and transformers for a second, there are places where it might make sense to display something other than "name". Here's an example: https://www.openstreetmap.org/way/407193053#map=18/52.94161/-1.13238 . As an example, it might make sense to use "lock_name" there instead of "name" and incorporate the ref. The result is https://map.atownsend.org.uk/maps/map/map.html#zoom=20&lat=52.9416056&lon=-1.132346 and it was done via lua in https://github.com/SomeoneElseOSM/SomeoneElse-style/blob/master/style.lua#L1152 .

Separately to that there are lots of things in this style that don't get names at all but arguably should - but that's a whole other issue.

@mboeringa
Copy link

mboeringa commented Nov 8, 2017

This is also a wholly impractical suggestion. There is a million potential keys out there that could potentially be used in a

KEYNAME:name

or

KEYNAME_name

construct.

Which one would need to be rendered, how would you ever decide? (everyone will have its own pet project...) Does a renderer need to check all million keys?... Renderers using a non HSTORE database, won't even be able to access them, as the data simply won't be there...

I also think the type of data you want to store, is often more suitable for the "ref" tag. Substations likely don't have a real name, but more likely a coded value for administrative and management purposes. Or if they do have a name, they are likely to have a ref as well for the same reasons.

@SomeoneElseOSM
Copy link
Contributor

SomeoneElseOSM commented Nov 8, 2017

I'd reject the idea that something that I've actually done is "wholly impractical" :)

Of course it's importany define which objects we're interested in rendering other names for (ones actually in widespread use in OSM data), which the initial comment didn't, but that doesn't mean that the idea is impractical.

@matkoniecz
Copy link
Contributor

matkoniecz commented Nov 8, 2017

Note that lock_name and similar may be discussed in their own separate issues, maybe some issues already exist for this ideas.

Closing this is not rejection of rendering name label using tags other than name in any situation.

@dieterdreist
Copy link

dieterdreist commented Nov 8, 2017 via email

@HolgerJeromin
Copy link
Contributor

lock_name is "discussed" here #157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants