Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Riverbanks aren't rendered #3333

Closed
Robot8A opened this issue Aug 7, 2018 · 6 comments
Closed

Riverbanks aren't rendered #3333

Robot8A opened this issue Aug 7, 2018 · 6 comments
Labels

Comments

@Robot8A
Copy link

Robot8A commented Aug 7, 2018

Expected behavior

They are rendered

Actual behavior

They aren't

Links and screenshots illustrating the problem

imagen

https://www.openstreetmap.org/#map=16/41.6543/-0.8646

@imagico
Copy link
Collaborator

imagico commented Aug 7, 2018

That is most likely because the multipolygon is broken which will be the case most of the time with unmaintainable crap like this:

https://www.openstreetmap.org/relation/16319

So the solution is to break this into well manageable pieces and they will show up nicely in the map (except for the low zoom levels of course where you will have to actively ignore the effects of #2873).

PS: You always should provide a link to the place where you observe a problem so people do not need to waste time in researching where you look at first.

@Tomasz-W
Copy link

Tomasz-W commented Aug 7, 2018

@Robot8A You can look for potential relation gaps/ errors here: http://ra.osmsurround.org/analyzeMap?relationId=16319

@Robot8A
Copy link
Author

Robot8A commented Aug 7, 2018

User Edvac changed the tagging to natural=water without changing any of its members and now it gets rendered

@mboeringa
Copy link

mboeringa commented Aug 7, 2018

@Robot8A ,

There was actually a single node that appears to have been accidentally moved at the very end of the Rio Ebro where it flows into the Mediterranean Sea, that caused a self intersection of the riverbank multipolygon.

This was easily detectable in JOSM, and the only error reported.

I have now fixed it. Actually, while I was on it, someone else (user Edvac) seems to have detected the same issue and already moved the offending node a bit to solve the self-intersection, causing a conflict with my edit. I resolved that, and then moved the node to a more appropriate location at the center of the riverbank, as Edvac forgot to do this.

So the issue should now be fine and resolved.

@mboeringa
Copy link

User Edvac changed the tagging to natural=water without changing any of its members and now it gets rendered

This has likely little to do with it. If the waterway=riverbank was rendered before, it should have been now without a change to natural=water, water=river. The self-interesection is a likely cause of a rendering error though, but now also resolved.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Aug 7, 2018

Since it's a tagging problem, I will close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants