Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering icon for craft=luthier #4777

Open
sylvain-m opened this issue Feb 13, 2023 · 4 comments
Open

Add rendering icon for craft=luthier #4777

sylvain-m opened this issue Feb 13, 2023 · 4 comments
Labels
amenity-points new features Requests to render new features

Comments

@sylvain-m
Copy link

sylvain-m commented Feb 13, 2023

Even if this tag (craft=luthier) is not very widespread (about a hundred POIs), it would be interesting to represent luthiers by a stringed instrument icon (violin or guitar for example).

https://taginfo.openstreetmap.org/tags/craft=luthier
https://en.wikipedia.org/wiki/Luthier

@sylvain-m
Copy link
Author

If this use is too rare [*], one could also group the display with craft=musical_instrument, or even with shop=musical_instrument.
As a minimum, a dot should be displayed, and with the name of the workshop at the most important zooms.

https://taginfo.openstreetmap.org/tags/craft=musical_instrument
https://taginfo.openstreetmap.org/tags/shop=musical_instrument

[*] I don't know how many occurrences are required to select a particular icon.

@imagico
Copy link
Collaborator

imagico commented Feb 13, 2023

Thanks for the suggestion

craft=luthier has 103 uses, almost exclusively in western Europe
craft=musical_instrument has 168 uses with only slightly wider distribution.

We so far lack a sustainable overall design concept of rendering crafts in this style - see #1697.

@imagico imagico added new features Requests to render new features amenity-points labels Feb 13, 2023
@sylvain-m
Copy link
Author

Thanks for the link to this issue, and indeed I notice that the rendering of the whole craft=* is missing...
I understand that the problem is much larger (and therefore complicated)

I hope that this issue will progress, because crafts POI deserve to appear on a general public map, at least by their name and a generic dot.

@kontrarie
Copy link

I should like to disagree with the suggestion to tag them as shop= : most shops will only sell; whereas a luthier is basically a builder of instriments, though she/he will usually do the "sales part": as far as I have observed, the vast majority are one-person enterprises.
OTOH I would support the more generic craft=musical+instrument, given the scarcity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amenity-points new features Requests to render new features
Projects
None yet
Development

No branches or pull requests

3 participants