Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(daffio, design-land): implement tree in daff.io and design-land navs #1824

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Sep 14, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Sidebar navs in daff.io and design-land don't have a good UI structure and consistency.

Fixes: N/A

What is the new behavior?

Implement tree component in daff.io and design-land sidebar navs for better UI structure and consistency.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added docs This issue is related to documentation package: daff.io @daffodil/daff.io labels Sep 14, 2021
@xelaint xelaint self-assigned this Sep 14, 2021
@xelaint xelaint requested review from a team as code owners September 14, 2021 14:39
@xelaint xelaint mentioned this pull request Sep 14, 2021
3 tasks
@xelaint xelaint requested a review from griest024 September 20, 2021 14:57
Copy link
Member

@griest024 griest024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good but acceptance tests are blocked by issues in #1622

@xelaint xelaint force-pushed the tree-implementation branch from 8e23279 to 2f68673 Compare January 11, 2022 20:48
@damienwebdev damienwebdev force-pushed the tree-implementation branch 2 times, most recently from a91f779 to 0130dac Compare April 24, 2023 21:10
@damienwebdev damienwebdev force-pushed the tree-implementation branch 6 times, most recently from e4e1304 to f62f228 Compare July 26, 2023 13:22
@damienwebdev damienwebdev requested a review from a team as a code owner July 26, 2023 13:22
@damienwebdev damienwebdev force-pushed the tree-implementation branch from f62f228 to df85b8c Compare July 26, 2023 13:46
damienwebdev pushed a commit that referenced this pull request Jul 26, 2023
@damienwebdev damienwebdev force-pushed the tree-implementation branch from df85b8c to bcf5692 Compare July 26, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This issue is related to documentation package: daff.io @daffodil/daff.io
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants