Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): expose colorable public_api to core's public_api #2487

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jun 29, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@xelaint xelaint added the package: design @daffodil/design label Jun 29, 2023
@xelaint xelaint self-assigned this Jun 29, 2023
@xelaint xelaint requested a review from a team as a code owner June 29, 2023 16:44
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev damienwebdev merged commit 5c7669d into develop Jun 30, 2023
@damienwebdev damienwebdev deleted the colorable-public branch June 30, 2023 13:22
@gray-bot gray-bot mentioned this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
Development

Successfully merging this pull request may close these issues.

2 participants