Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): remove auth token in unauthenticated hook #2523

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

removing the auth token is spread around the codebase

What is the new behavior?

removing the auth token is consolidated into a single place and guaranteed to complete before client cache reset

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@griest024 griest024 added the package: auth @daffodil/auth label Jul 31, 2023
@griest024 griest024 requested a review from a team as a code owner July 31, 2023 18:05
@griest024 griest024 force-pushed the feat/auth/remove-token-in-hook branch from cbccc25 to 95a3942 Compare July 31, 2023 18:25
@griest024 griest024 merged commit 6472f8f into develop Jul 31, 2023
@gray-bot gray-bot mentioned this pull request Jul 31, 2023
@griest024 griest024 deleted the feat/auth/remove-token-in-hook branch July 31, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: auth @daffodil/auth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant