Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): create focus stack service #2570

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Sep 22, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

We currently don't have a way of moving focus back to the activator of modal-like elements. Currently, focus can jump into the modal-like element when it opens, but when it closes, focus is lost and is reset to the body.

Fixes: #2565

What is the new behavior?

This service allows for focus to be placed back on the activator when the element is closed.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added help wanted Extra attention is needed for this PR or issue package: design @daffodil/design labels Sep 22, 2023
@xelaint xelaint requested a review from a team as a code owner September 22, 2023 18:32
@xelaint xelaint self-assigned this Sep 22, 2023
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev damienwebdev merged commit f5f206b into develop Sep 26, 2023
13 checks passed
damienwebdev added a commit that referenced this pull request Sep 26, 2023
Co-authored-by: Damien Retzinger <damienwebdev@gmail.com>
@gray-bot gray-bot mentioned this pull request Sep 26, 2023
@damienwebdev damienwebdev changed the title feat(shop): create focus stack service feat(design): create focus stack service Sep 26, 2023
@damienwebdev damienwebdev deleted the focus-stack-service branch September 26, 2023 12:49
@xelaint xelaint removed the help wanted Extra attention is needed for this PR or issue label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
Development

Successfully merging this pull request may close these issues.

[FEAT] Focus Stack Service
2 participants