Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(daffio): dynamic nav and sidebar content #2686

Merged
merged 18 commits into from
Jan 9, 2024

Conversation

griest024
Copy link
Member

@griest024 griest024 commented Dec 22, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #2680, #2676
Part of: #2681

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

changes sidebar and nav to use the named view. Note that this means that sidebars and navs will only appear on routes that have them defined (currently only docs and home, respectively)

@griest024 griest024 added package: daff.io @daffodil/daff.io status: awaiting review This PR is awaiting review labels Dec 22, 2023
@griest024 griest024 requested review from a team as code owners December 22, 2023 22:32
@griest024
Copy link
Member Author

@xelaint while this can be merged now, I think its best to create the other pages and sidebars based on this as an acceptance test

@xelaint xelaint added this to the Daffodil v1.0 milestone Dec 28, 2023
@griest024
Copy link
Member Author

@damienwebdev what do you think about namedOutlet instead of namedView?

@xelaint
Copy link
Member

xelaint commented Jan 2, 2024

@griest024 There's a weird bug where the sidebar guides list doesn't generate until I refresh the page. https://www.loom.com/share/8b3a3f09d4a4487e887667910cec69cc?sid=3dc6ff9f-1732-454f-8b80-938063e9512a

@xelaint xelaint force-pushed the feat/daffio/sidebar-content branch from 06dc2af to f884820 Compare January 2, 2024 21:11
@griest024
Copy link
Member Author

@griest024 There's a weird bug where the sidebar guides list doesn't generate until I refresh the page. https://www.loom.com/share/8b3a3f09d4a4487e887667910cec69cc?sid=3dc6ff9f-1732-454f-8b80-938063e9512a

fixed this

@xelaint xelaint changed the title feat(daffio): dynamic sidebar content feat(daffio): dynamic nav and sidebar content Jan 3, 2024
xelaint
xelaint previously approved these changes Jan 8, 2024
@griest024 griest024 added status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin and removed status: awaiting review This PR is awaiting review labels Jan 9, 2024
@griest024 griest024 merged commit 4fe945c into graycoreio:develop Jan 9, 2024
8 checks passed
@gray-bot gray-bot mentioned this pull request Jan 9, 2024
@griest024 griest024 deleted the feat/daffio/sidebar-content branch January 9, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: daff.io @daffodil/daff.io status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin
Projects
None yet
2 participants