-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(daffio): dynamic nav and sidebar content #2686
feat(daffio): dynamic nav and sidebar content #2686
Conversation
@xelaint while this can be merged now, I think its best to create the other pages and sidebars based on this as an acceptance test |
@damienwebdev what do you think about |
@griest024 There's a weird bug where the sidebar guides list doesn't generate until I refresh the page. https://www.loom.com/share/8b3a3f09d4a4487e887667910cec69cc?sid=3dc6ff9f-1732-454f-8b80-938063e9512a |
06dc2af
to
f884820
Compare
apps/daffio/src/app/core/sidebar/containers/sidebar-viewport/sidebar-viewport.component.html
Show resolved
Hide resolved
fixed this |
5495655
to
978b0fb
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Fixes: #2680, #2676
Part of: #2681
Does this PR introduce a breaking change?
Other information
changes sidebar and nav to use the named view. Note that this means that sidebars and navs will only appear on routes that have them defined (currently only docs and home, respectively)