Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(daffio)!: use ng17 version of vercel build #2739

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

damienwebdev
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Currently, the next.daff.io site is down as a result of the upgrade to Angular 17. The specific cause is the transition from cjs to esm and resulting differences in Vercel and https://github.com/graycoreio/github-actions/tree/main/angular-universal-vercel

Fixes: N/A

What is the new behavior?

We no longer need to webpack bundle the server module, we can just build and https://github.com/graycoreio/github-actions/tree/main/angular-universal-vercel will handle the rest.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

The internal developer api of lerna run build has changed for @daffodil/daffio.

Other information

Previously, used webpack to bundle the serverless app together.
We no longer have to do this due to support for ng17 and esm chunks in
https://github.com/graycoreio/github-actions/tree/main/angular-universal-vercel
@damienwebdev damienwebdev requested review from a team as code owners January 29, 2024 17:04
@damienwebdev damienwebdev merged commit 5097583 into develop Jan 29, 2024
3 of 4 checks passed
@damienwebdev damienwebdev deleted the fix_daffio branch January 29, 2024 17:05
@gray-bot gray-bot mentioned this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant