Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): allow the whole typography subpackaged to be exported and allow body-font-family variable to be assignable #2762

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Feb 21, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The body-font-family variable can't be customized by a user.

Part of: #1880

What is the new behavior?

Add a !default flag to $font-family-base and $font-family-mono so that it's set as default but can be overridden by a Daffodil user.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added feat a new feature, enhancement, or improvement package: design @daffodil/design status: awaiting review This PR is awaiting review labels Feb 21, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone Feb 21, 2024
@xelaint xelaint requested a review from damienwebdev February 21, 2024 10:40
@xelaint xelaint requested a review from a team as a code owner February 21, 2024 10:40
@xelaint xelaint removed the feat a new feature, enhancement, or improvement label Feb 21, 2024
@xelaint xelaint marked this pull request as draft February 22, 2024 09:55
@xelaint xelaint removed the status: awaiting review This PR is awaiting review label Feb 22, 2024
@xelaint xelaint force-pushed the default-variables-update branch from 1e97f61 to f752926 Compare February 23, 2024 12:53
@xelaint xelaint marked this pull request as ready for review February 23, 2024 12:53
@xelaint xelaint added the status: awaiting review This PR is awaiting review label Feb 23, 2024
@xelaint xelaint changed the title feat(design): allow the body-font-family variable to be assignable feat(design): allow the whole typography subpackaged to be exported and allow body-font-family variable to be assignable Feb 23, 2024
@xelaint xelaint force-pushed the default-variables-update branch from f752926 to ce4cad8 Compare June 21, 2024 17:37
…nd allow body-font-family variable to be assignable
@xelaint xelaint force-pushed the default-variables-update branch from 8439dfc to 7c2126d Compare June 21, 2024 20:13
@xelaint xelaint merged commit 36dbfe8 into develop Jul 1, 2024
13 checks passed
@gray-bot gray-bot mentioned this pull request Jul 1, 2024
@damienwebdev damienwebdev deleted the default-variables-update branch October 18, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design status: awaiting review This PR is awaiting review
Projects
Development

Successfully merging this pull request may close these issues.

2 participants