Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add subpackage for external scripts #2773

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Conversation

damienwebdev
Copy link
Member

@damienwebdev damienwebdev commented Mar 28, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

We currently have code for Authorize.net that's not very extensible or friendly. . I needed a similar bit of code to load some other external javascript dynamically and I wanted to abstract the core of this behavior.

Fixes: N/A

What is the new behavior?

This adds a new subpackage for loading third-party javascript dynamically in a document. This will likely be useful when interacting with third-party widgets and payment APIs.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This adds a new subpackage for loading third-party javascript dynamically
in a document. This will likely be useful when interacting with
third-party widgets and payment APIs.
Copy link
Member

@griest024 griest024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one missing doc but otherwise lgtm

libs/core/external-script/src/script.ts Show resolved Hide resolved
@damienwebdev damienwebdev merged commit 53b0d65 into develop Apr 24, 2024
50 checks passed
@damienwebdev damienwebdev deleted the external-scripts branch April 24, 2024 14:17
@gray-bot gray-bot mentioned this pull request Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants