Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add identity function #2785

Merged
merged 1 commit into from
May 13, 2024

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the new behavior?

While this might seem useless, its nice to have a single function that will be used for places where transforms are required by type but no transform logic is needed (will happen for injectable actions). This prevents multiple identity functions being created (as they would if defined inline, though possibly closured out) which should improve memory usage.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@griest024 griest024 added package: core @daffodil/core status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin labels May 13, 2024
@griest024 griest024 self-assigned this May 13, 2024
@griest024 griest024 requested a review from a team as a code owner May 13, 2024 17:03
@griest024 griest024 merged commit 5c6aa86 into graycoreio:develop May 13, 2024
50 checks passed
@griest024 griest024 deleted the feat/core/identity branch May 13, 2024 18:50
@gray-bot gray-bot mentioned this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @daffodil/core status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant