feat(core): replace mutating with updating #2787
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
While mutating is a valuable concept, having it treated as a distinct state alongside
Adding
andDeleting
causes confusion. Adding and deleting are also mutable operation states, though the concept of anenum
indicates that they are distinct. AligningDaffState
more closely with CRUD distinctions presents a more familiar and predicatable operation state model.The concept of mutating will still be supported at a state layer as an OR of adding, updating, or deleting.
The only possible concern here is the inability to determine the exact role of an operation as it pertains to the CRUD paradigm and therefore being unable to make a good choice as to the
DaffState
to represent the operation.Mutating
andMutated
are, for this reason, left in a deprecated state (rather than removed) to further evaluate the use cases.Does this PR introduce a breaking change?
Other information