Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cart,cart-store-credit)!: remove DaffCartShippingInformation #2788

Merged

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the new behavior?

DaffCartShippingInformation has never seen any actual use cases presented. It's bothersome and is therefore removed.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

DaffCartShippingInformation has been removed. Use DaffCartShippingRate instead

Other information

BREAKING CHANGE: `DaffCartShippingInformation` has been removed. Use `DaffCartShippingRate` instead
@griest024 griest024 added package: cart @daffodil/cart 🚨 breaking changes This PR or issue will cause a breaking change package: cart-store-credit @daffodil/cart-store-credit labels May 13, 2024
@griest024 griest024 self-assigned this May 13, 2024
@griest024 griest024 requested a review from a team as a code owner May 13, 2024 17:15
@griest024 griest024 merged commit b4cc19b into graycoreio:develop May 13, 2024
18 checks passed
@gray-bot gray-bot mentioned this pull request May 13, 2024
@griest024 griest024 deleted the feat/cart/remove-shipping-info branch May 13, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 breaking changes This PR or issue will cause a breaking change package: cart @daffodil/cart package: cart-store-credit @daffodil/cart-store-credit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant