feat(seo)!: remove explicit dep on ngrx/router-store #2817
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Previously, if you wanted to use SEO, you had to install
ngrx/router-store
. This is an annoying dep that we don't really want to use any more.Fixes: N/A
What is the new behavior?
You can now import from
@daffodil/seo/router
or@daffodil/seo/state
depending on what packages you have installed and want to use.Additionally, in support of removing ngModules and preferring feature providers, I've removed the
DaffSeoNativeStateModule
.Does this PR introduce a breaking change?
BREAKING CHANGE: The following tokens are now exported from
@daffodil/seo/router
:You can simply adjust the imports from
@daffodil/seo/state
to@daffodil/seo/router
.Additionally,
DaffSeoNativeStateModule
has been removed in favor of feature providers like:daffSeoRouterTitleProvider
,daffSeoRouterMetaProvider
anddaffSeoRouterCanonicalProvider