Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(seo)!: remove explicit dep on ngrx/router-store #2817

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

damienwebdev
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Previously, if you wanted to use SEO, you had to install ngrx/router-store. This is an annoying dep that we don't really want to use any more.

Fixes: N/A

What is the new behavior?

You can now import from @daffodil/seo/router or @daffodil/seo/state depending on what packages you have installed and want to use.

Additionally, in support of removing ngModules and preferring feature providers, I've removed the DaffSeoNativeStateModule.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

BREAKING CHANGE: The following tokens are now exported from @daffodil/seo/router:

DaffSeoUpdateEventPair
DAFF_SEO_META_ROUTER_UPDATES
daffProvideMetaRouterUpdates
DAFF_SEO_CANONICAL_URL_ROUTER_UPDATES
daffProvideCanonicalUrlRouterUpdates
DAFF_SEO_TITLE_ROUTER_UPDATES
daffProvideTitleRouterUpdates
daffSeoRouterTitleProvider
daffSeoRouterMetaProvider
daffSeoRouterCanonicalProvider

You can simply adjust the imports from @daffodil/seo/state to @daffodil/seo/router.

Additionally, DaffSeoNativeStateModule has been removed in favor of feature providers like: daffSeoRouterTitleProvider, daffSeoRouterMetaProvider and daffSeoRouterCanonicalProvider

BREAKING CHANGE: The following tokens are now exported from `@daffodil/seo/router`:

```
DaffSeoUpdateEventPair
DAFF_SEO_META_ROUTER_UPDATES
daffProvideMetaRouterUpdates
DAFF_SEO_CANONICAL_URL_ROUTER_UPDATES
daffProvideCanonicalUrlRouterUpdates
DAFF_SEO_TITLE_ROUTER_UPDATES
daffProvideTitleRouterUpdates
daffSeoRouterTitleProvider
daffSeoRouterMetaProvider
daffSeoRouterCanonicalProvider
```

You can simply adjust the imports from `@daffodil/seo/state` to `@daffodil/seo/router`.

Additionally, `DaffSeoNativeStateModule` has been removed in favor of feature providers like: `daffSeoRouterTitleProvider`, `daffSeoRouterMetaProvider` and `daffSeoRouterCanonicalProvider`
@damienwebdev damienwebdev requested a review from a team as a code owner May 29, 2024 16:05
Copy link
Member

@griest024 griest024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add @daffodil/seo/router to tsconfig.json

@griest024 griest024 added the status: needs response This PR is waiting for a response from the author label Jun 5, 2024
@damienwebdev
Copy link
Member Author

@griest024 fixed.

@damienwebdev damienwebdev requested a review from griest024 July 29, 2024 17:29
@damienwebdev damienwebdev merged commit e953dca into develop Jul 29, 2024
8 checks passed
@damienwebdev damienwebdev deleted the seo_router_subpackage branch July 29, 2024 17:41
@gray-bot gray-bot mentioned this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs response This PR is waiting for a response from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants