Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(navigation): deep fragment fields might not get data #2889

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

this is a workaround of magento/magento2#38863

@griest024 griest024 added package: navigation @daffodil/navigation platform: magento This PR or issue is related to Magento layer: driver This PR or issue is related to the driver layer of Daffodil status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin labels Jun 21, 2024
@griest024 griest024 self-assigned this Jun 21, 2024
@griest024 griest024 requested a review from a team as a code owner June 21, 2024 18:10
@griest024 griest024 changed the title fix(navgiation): deep fragment fields might not get data fix(navigation): deep fragment fields might not get data Jun 21, 2024
@griest024 griest024 merged commit 44d16d7 into graycoreio:develop Jun 21, 2024
9 checks passed
@gray-bot gray-bot mentioned this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
layer: driver This PR or issue is related to the driver layer of Daffodil package: navigation @daffodil/navigation platform: magento This PR or issue is related to Magento status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant