-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(design)!: make design examples standalone #2924
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damienwebdev
changed the title
Standalone design examples
feat(design): make design examples standalone
Jul 19, 2024
damienwebdev
changed the title
feat(design): make design examples standalone
feat(design)!: make design examples standalone
Jul 19, 2024
damienwebdev
force-pushed
the
standalone_design_examples
branch
2 times, most recently
from
July 19, 2024 16:01
5e9aff6
to
829f4df
Compare
xelaint
added
package: design
@daffodil/design
🚨 breaking changes
This PR or issue will cause a breaking change
labels
Jul 19, 2024
damienwebdev
force-pushed
the
standalone_design_examples
branch
from
July 22, 2024 13:30
829f4df
to
92f8cba
Compare
damienwebdev
force-pushed
the
standalone_design_examples
branch
from
July 22, 2024 18:01
92f8cba
to
c20e3f6
Compare
3 tasks
xelaint
requested changes
Jul 23, 2024
...notification/examples/src/notification-with-actions/notification-with-actions.component.html
Outdated
Show resolved
Hide resolved
damienwebdev
force-pushed
the
standalone_design_examples
branch
from
July 23, 2024 14:44
c20e3f6
to
d144ddd
Compare
damienwebdev
force-pushed
the
standalone_design_examples
branch
from
July 29, 2024 14:54
d144ddd
to
9a58863
Compare
damienwebdev
force-pushed
the
standalone_design_examples
branch
from
July 29, 2024 17:01
9a58863
to
2144cee
Compare
BREAKING CHANGE: This removes the ComponentExampleWithModule and ComponentExample that were unintentionally exported from `@daffodil/design`. These types were never meant to be used by consumers.
damienwebdev
force-pushed
the
standalone_design_examples
branch
from
July 29, 2024 17:24
2144cee
to
f52244f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract from #2909