Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): SSR gets stuck in resolver when query is empty #2954

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

In SSR when the search query is empty, the resolver will wait forever and the page will never load.

What is the new behavior?

When the query is empty, the resolver will essentially do nothing and just proceed with navigation.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@griest024 griest024 added package: search @daffodil/search status: awaiting review This PR is awaiting review labels Aug 5, 2024
@griest024 griest024 requested a review from a team as a code owner August 5, 2024 20:28
@griest024 griest024 added the layer: routing This PR or issue is related to the routing layer label Aug 5, 2024
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev damienwebdev merged commit 16b6000 into graycoreio:develop Aug 6, 2024
12 checks passed
@gray-bot gray-bot mentioned this pull request Aug 6, 2024
@griest024 griest024 deleted the fix/search/routing/server-side-empty-query branch August 8, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
layer: routing This PR or issue is related to the routing layer package: search @daffodil/search status: awaiting review This PR is awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants