Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design)!: rename base background token name #2969

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Aug 14, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

BREAKING CHANGE: --daff-base-background has been renamed to --daff-base-bg in favor of shortened variable names.

Other information

@xelaint xelaint added package: design @daffodil/design 🚨 breaking changes This PR or issue will cause a breaking change labels Aug 14, 2024
@xelaint xelaint requested review from a team as code owners August 14, 2024 14:11
@xelaint xelaint merged commit 4d91fb5 into develop Aug 14, 2024
13 checks passed
@gray-bot gray-bot mentioned this pull request Aug 14, 2024
@damienwebdev damienwebdev deleted the tokens-update branch October 18, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 breaking changes This PR or issue will cause a breaking change package: design @daffodil/design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant