Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): clean up link code styles within blockquote in DaffArticleComponent #2972

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Aug 14, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

code blocks that are also links in blockquotes are not styled correctly.

Fixes: N/A

What is the new behavior?

Update colors for code block links within blockquotes.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added the package: design @daffodil/design label Aug 14, 2024
@xelaint xelaint requested a review from a team as a code owner August 14, 2024 15:30
@xelaint xelaint changed the title feat(design): clean up llink code styles within blockquote in DaffArticleComponent feat(design): clean up link code styles within blockquote in DaffArticleComponent Aug 14, 2024
@xelaint xelaint merged commit 9302ee2 into develop Aug 14, 2024
13 checks passed
@gray-bot gray-bot mentioned this pull request Aug 14, 2024
@damienwebdev damienwebdev deleted the article-blockquote-code-style branch October 18, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant