Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(daffio): trailing slash missing from docs path #2976

Merged

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

There is ambiguity in whether the docs path has a trailing /. A missing trailing slash will cause an exception.

What is the new behavior?

The resolver always adds an extra / and removes any double slashes.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@griest024 griest024 added the package: daff.io @daffodil/daff.io label Aug 14, 2024
@griest024 griest024 self-assigned this Aug 14, 2024
@griest024 griest024 requested review from a team as code owners August 14, 2024 18:10
@griest024 griest024 added the status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin label Aug 14, 2024
@griest024 griest024 merged commit 5392e37 into graycoreio:develop Aug 14, 2024
8 checks passed
@griest024 griest024 deleted the fix/daffio/trailing-slash-missing branch August 14, 2024 18:22
@gray-bot gray-bot mentioned this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: daff.io @daffodil/daff.io status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant