-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dgeni,daffio): render package API doc exports #2991
Merged
griest024
merged 3 commits into
graycoreio:develop
from
griest024:feat/dgeni/api-package-contents
Aug 22, 2024
Merged
feat(dgeni,daffio): render package API doc exports #2991
griest024
merged 3 commits into
graycoreio:develop
from
griest024:feat/dgeni/api-package-contents
Aug 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
griest024
added
🚨 breaking changes
This PR or issue will cause a breaking change
tools: dgeni
@daffodil/tools-dgeni
labels
Aug 16, 2024
griest024
changed the title
feat(dgeni)!: add exports to package API docs
feat(dgeni): add exports to package API docs
Aug 16, 2024
griest024
changed the title
feat(dgeni): add exports to package API docs
feat(dgeni,daffio): render package API doc exports
Aug 16, 2024
griest024
added
package: daff.io
@daffodil/daff.io
and removed
🚨 breaking changes
This PR or issue will cause a breaking change
labels
Aug 16, 2024
xelaint
reviewed
Aug 21, 2024
apps/daffio/src/app/docs/api/components/api-list-children/api-list-children.component.html
Outdated
Show resolved
Hide resolved
apps/daffio/src/app/docs/components/doc-viewer/doc-viewer.component.html
Outdated
Show resolved
Hide resolved
@griest024 I also need to make updates to the UI of list items in the api list. LMK when I can do that. |
@xelaint you can go ahead and make UI updates |
xelaint
force-pushed
the
feat/dgeni/api-package-contents
branch
from
August 21, 2024 19:03
72cdc25
to
34890c6
Compare
@griest024 Is there a way to pull this section of the readme and add it to the page? |
@griest024 Is there a way to pull this section of the readme and add it to the page? hm yeah, technically. I think this is better pulled from the |
xelaint
approved these changes
Aug 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
package: daff.io
@daffodil/daff.io
status: awaiting review
This PR is awaiting review
tools: dgeni
@daffodil/tools-dgeni
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Fixes: #2816, fixes: #2971
What is the new behavior?
Does this PR introduce a breaking change?
Other information