-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs-utils,dgeni): generate breadcrumbs from doc path #3047
Merged
griest024
merged 11 commits into
graycoreio:develop
from
griest024:feat/dgeni/api/breadcrumbs
Sep 19, 2024
Merged
feat(docs-utils,dgeni): generate breadcrumbs from doc path #3047
griest024
merged 11 commits into
graycoreio:develop
from
griest024:feat/dgeni/api/breadcrumbs
Sep 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
griest024
added
status: awaiting review
This PR is awaiting review
package: docs-utils
@daffodil/docs-utils
tools: dgeni
@daffodil/tools-dgeni
labels
Sep 3, 2024
@griest024 can you add the implementation of it using the |
blocked by #3063 |
griest024
force-pushed
the
feat/dgeni/api/breadcrumbs
branch
from
September 13, 2024 21:00
beed3b5
to
a04732e
Compare
done |
griest024
force-pushed
the
feat/dgeni/api/breadcrumbs
branch
from
September 13, 2024 21:01
a04732e
to
1458bf7
Compare
truncate current breadcrumb label |
griest024
force-pushed
the
feat/dgeni/api/breadcrumbs
branch
from
September 17, 2024 18:01
9c4bbf7
to
39508a6
Compare
griest024
added
status: awaiting review
This PR is awaiting review
and removed
status: wip
This PR is WIP. It should be marked as a draft.
labels
Sep 17, 2024
@xelaint ready for re-review |
xelaint
requested changes
Sep 17, 2024
apps/daffio/src/app/docs/components/doc-viewer/doc-viewer.module.ts
Outdated
Show resolved
Hide resolved
xelaint
previously approved these changes
Sep 18, 2024
also creates a lot of processor providers so they aren't singletons
griest024
force-pushed
the
feat/dgeni/api/breadcrumbs
branch
from
September 19, 2024 19:10
efc26b6
to
b8eaee7
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
package: docs-utils
@daffodil/docs-utils
status: awaiting review
This PR is awaiting review
tools: dgeni
@daffodil/tools-dgeni
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Fixes: #3046, fixes: #2973
What is the new behavior?
Does this PR introduce a breaking change?
Other information
The guides and packages aren't quite as clean as the API since there isn't a doc at every level of the tree.