Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs-utils,dgeni): generate breadcrumbs from doc path #3047

Merged
merged 11 commits into from
Sep 19, 2024

Conversation

griest024
Copy link
Member

@griest024 griest024 commented Sep 3, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #3046, fixes: #2973

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

The guides and packages aren't quite as clean as the API since there isn't a doc at every level of the tree.

@griest024 griest024 added status: awaiting review This PR is awaiting review package: docs-utils @daffodil/docs-utils tools: dgeni @daffodil/tools-dgeni labels Sep 3, 2024
@griest024 griest024 marked this pull request as ready for review September 3, 2024 17:29
@griest024 griest024 requested review from a team as code owners September 3, 2024 17:29
@xelaint
Copy link
Member

xelaint commented Sep 11, 2024

@griest024 can you add the implementation of it using the DaffBreadcrumbComponent?

@griest024
Copy link
Member Author

blocked by #3063

@griest024 griest024 marked this pull request as draft September 12, 2024 16:59
@griest024 griest024 force-pushed the feat/dgeni/api/breadcrumbs branch from beed3b5 to a04732e Compare September 13, 2024 21:00
@griest024 griest024 marked this pull request as ready for review September 13, 2024 21:00
@griest024 griest024 requested review from a team as code owners September 13, 2024 21:00
@griest024
Copy link
Member Author

@griest024 can you add the implementation of it using the DaffBreadcrumbComponent?

done

@griest024 griest024 force-pushed the feat/dgeni/api/breadcrumbs branch from a04732e to 1458bf7 Compare September 13, 2024 21:01
@griest024 griest024 requested a review from xelaint September 16, 2024 15:20
@griest024 griest024 removed the status: awaiting review This PR is awaiting review label Sep 17, 2024
@griest024
Copy link
Member Author

truncate current breadcrumb label

@griest024 griest024 marked this pull request as draft September 17, 2024 15:03
@griest024 griest024 added the status: wip This PR is WIP. It should be marked as a draft. label Sep 17, 2024
@griest024 griest024 force-pushed the feat/dgeni/api/breadcrumbs branch from 9c4bbf7 to 39508a6 Compare September 17, 2024 18:01
@griest024 griest024 marked this pull request as ready for review September 17, 2024 18:01
@griest024 griest024 added status: awaiting review This PR is awaiting review and removed status: wip This PR is WIP. It should be marked as a draft. labels Sep 17, 2024
@griest024
Copy link
Member Author

@xelaint ready for re-review

xelaint
xelaint previously approved these changes Sep 18, 2024
@griest024 griest024 force-pushed the feat/dgeni/api/breadcrumbs branch from efc26b6 to b8eaee7 Compare September 19, 2024 19:10
@griest024 griest024 merged commit 0e0ca5b into graycoreio:develop Sep 19, 2024
10 of 11 checks passed
@griest024 griest024 deleted the feat/dgeni/api/breadcrumbs branch September 19, 2024 19:48
@gray-bot gray-bot mentioned this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: docs-utils @daffodil/docs-utils status: awaiting review This PR is awaiting review tools: dgeni @daffodil/tools-dgeni
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate breadcrumb data with dgeni [FEAT] Breadcrumbs on top of docs pages
2 participants