Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demo): in-memory driver never gets loaded #3051

Merged

Conversation

griest024
Copy link
Member

@griest024 griest024 commented Sep 4, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the old behavior?

For reasons I cannot discern, the driver module loading logic always loads the magento module, no matter the environment (which is correctly file replaced and imported).

What is the new behavior?

Loads correct driver module via file replacements

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

blocks #3049

@griest024 griest024 added package: demo @daffodil/demo status: awaiting review This PR is awaiting review labels Sep 4, 2024
@griest024 griest024 requested review from a team as code owners September 4, 2024 22:25
@griest024 griest024 mentioned this pull request Sep 8, 2024
3 tasks
@griest024 griest024 merged commit d4df739 into graycoreio:develop Sep 17, 2024
8 checks passed
@gray-bot gray-bot mentioned this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: demo @daffodil/demo status: awaiting review This PR is awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant