Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-config): restrict window global access #3053

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Its easy to write SSR unsafe code.

What is the new behavior?

The linter throws if window is accessed via the global.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@griest024 griest024 added the status: awaiting review This PR is awaiting review label Sep 9, 2024
@griest024 griest024 requested a review from a team as a code owner September 9, 2024 14:31
damienwebdev
damienwebdev previously approved these changes Sep 9, 2024
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is brilliant!

@damienwebdev damienwebdev removed the status: awaiting review This PR is awaiting review label Sep 9, 2024
@damienwebdev damienwebdev self-assigned this Sep 9, 2024
@damienwebdev damienwebdev added this to the Daffodil v1.0 milestone Sep 9, 2024
@griest024 griest024 requested a review from a team as a code owner September 9, 2024 14:43
@griest024 griest024 merged commit 8b278ae into graycoreio:develop Sep 9, 2024
52 checks passed
@gray-bot gray-bot mentioned this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants