Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dgeni): render subpackages under root package #3063

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #3055

What is the new behavior?

image

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@griest024 griest024 added status: awaiting review This PR is awaiting review tools: dgeni @daffodil/tools-dgeni labels Sep 12, 2024
@griest024 griest024 requested a review from a team as a code owner September 12, 2024 14:35
@xelaint
Copy link
Member

xelaint commented Sep 12, 2024

Would we be able to do something like this on the root package page?

Screen Shot 2024-09-12 at 1 29 22 PM

@griest024
Copy link
Member Author

Would we be able to do something like this on the root package page?

Screen Shot 2024-09-12 at 1 29 22 PM

sure, but I think that should be a separate PR

@griest024 griest024 merged commit ccf41f6 into graycoreio:develop Sep 13, 2024
10 checks passed
@griest024 griest024 deleted the feat/dgeni/render-subpackages-under-parent branch September 13, 2024 15:37
@gray-bot gray-bot mentioned this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting review This PR is awaiting review tools: dgeni @daffodil/tools-dgeni
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Subpackages should be rendered within the main package in docsgen
2 participants