Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(driver): allow undefined extensions key in Magento graphql responses #3087

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

damienwebdev
Copy link
Member

@damienwebdev damienwebdev commented Sep 18, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Once you upgrade to v2.4.6 you will see errors like Cannot read properties of undefined (reading 'category') when Magento throws certain kinds of error.

Fixes: N/A

What is the new behavior?

In Magento versions that support GraphQl prior to v2.4.6 there was a key errors called "extensions" that contained an error code indicating what kind of error you received. For whatever reason, in v2.4.6 they removed this. This PR allows this extensions key to not exist when it used to always exist.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

In Magento versions that support GraphQl prior to v2.4.6 there was a key errors
called "extensions" that contained an error code indicating what kind of error you received.
For whatever reason, in v2.4.6 they removed this.

Once you upgrade to v2.4.6 you will see errors like `Cannot read properties of undefined (reading 'category')` as a result.
@damienwebdev damienwebdev requested a review from a team as a code owner September 18, 2024 17:36
@damienwebdev damienwebdev merged commit 64e9ce3 into develop Sep 18, 2024
42 checks passed
@damienwebdev damienwebdev deleted the fix_magento_v2.4.6_errors branch September 18, 2024 18:13
@gray-bot gray-bot mentioned this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants