-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(daffio): add design docs route #3113
feat(daffio): add design docs route #3113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Top nav should stay the same as the primary /docs
nav, except Design
needs to be added as a nav item, which navigates to docs/design
Examples
is not going to be path that we'll be using since all examples will be housed within the overview tab.Packages
should be changed toComponents
docs/design
should be a custom page not rendered by a README. It's going to look something like this (I can do the UI for it, just needed the route set up)
- The API reference page for each component is going to be displayed in the form of a tab within the component page.
b9912ca
to
d2ddeef
Compare
@xelaint I've reworked the design docs structure to hopefully match your requirements. Note there are two issues that should be handled in future PRs and not block this one:
|
apps/daffio/src/app/docs/design/containers/docs-list/docs-list.component.ts
Outdated
Show resolved
Hide resolved
|
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Part of: #2684
What is the new behavior?
Does this PR introduce a breaking change?
Other information
#3112 is an issue but shouldn't block this PR