Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design): update the property used to set a default alignment on callout #3118

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Sep 24, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

textAlignment is used to set a "default" on callout. defaultAlignment is the correct property to use, otherwise text alignment will always be what's set in the callout.

Fixes: #3117

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added the package: design @daffodil/design label Sep 24, 2024
@xelaint xelaint requested a review from a team as a code owner September 24, 2024 18:15
@xelaint xelaint merged commit 839afbd into develop Sep 24, 2024
13 checks passed
@gray-bot gray-bot mentioned this pull request Sep 24, 2024
@damienwebdev damienwebdev deleted the callout-text-alignment-bug branch October 18, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] textAlignment property in DaffCalloutComponent is not working as expected
1 participant