Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cart): support in-memory backend delegate #3180

Merged
merged 3 commits into from
Oct 10, 2024
Merged

feat(cart): support in-memory backend delegate #3180

merged 3 commits into from
Oct 10, 2024

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #3151

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@griest024 griest024 added the package: cart @daffodil/cart label Oct 10, 2024
@griest024 griest024 requested a review from a team as a code owner October 10, 2024 15:12
@griest024 griest024 requested review from a team as code owners October 10, 2024 15:44
@griest024 griest024 added layer: driver This PR or issue is related to the driver layer of Daffodil status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin platform: in-memory labels Oct 10, 2024
@griest024 griest024 added the 🚨 breaking changes This PR or issue will cause a breaking change label Oct 10, 2024
@griest024 griest024 merged commit a8360df into graycoreio:develop Oct 10, 2024
18 checks passed
@griest024 griest024 deleted the feat/cart/driver/in-memory/support-delegated-backend branch October 10, 2024 16:24
@gray-bot gray-bot mentioned this pull request Oct 10, 2024
Merged
gracetxgao pushed a commit to gracetxgao/daffodil that referenced this pull request Oct 24, 2024
@griest024 @gracetxgao
feat(cart)!: support in-memory backend delegate (graycoreio#3180)
0f4e199 
BREAKING CHANGE: `COLLECTION_NAMES` has been removed. Use `canHandle` to check backend routing capabilities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🚨 breaking changes This PR or issue will cause a breaking change layer: driver This PR or issue is related to the driver layer of Daffodil package: cart @daffodil/cart platform: in-memory status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Implement the in-memory backend interface for @daffodil/cart
1 participant
@griest024