Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): update DaffStatus danger value to critical and add an info value #3293

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Oct 17, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

What is the new behavior?

DaffStatus now includes info as a value, and danger has been updated to critical.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

BREAKING CHANGE: the danger value in DaffStatus has been changed to critical.

Other information

@xelaint xelaint added package: design @daffodil/design 🚨 breaking changes This PR or issue will cause a breaking change labels Oct 17, 2024
@xelaint xelaint requested a review from a team as a code owner October 17, 2024 17:00
@xelaint xelaint merged commit e3365b2 into develop Oct 17, 2024
13 checks passed
@gray-bot gray-bot mentioned this pull request Oct 17, 2024
@damienwebdev damienwebdev deleted the statusable-update branch October 18, 2024 14:21
gracetxgao pushed a commit to gracetxgao/daffodil that referenced this pull request Oct 24, 2024
…n info value (graycoreio#3293)

BREAKING CHANGE: the `danger` value in `DaffStatus` has been changed to `critical`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 breaking changes This PR or issue will cause a breaking change package: design @daffodil/design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Update DaffStatusable input options
1 participant