Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Create daff-map-get function #3309

Open
xelaint opened this issue Oct 22, 2024 · 0 comments · May be fixed by #3358
Open

[FEAT] Create daff-map-get function #3309

xelaint opened this issue Oct 22, 2024 · 0 comments · May be fixed by #3358
Assignees
Labels
feat a new feature, enhancement, or improvement package: design @daffodil/design
Milestone

Comments

@xelaint
Copy link
Member

xelaint commented Oct 22, 2024

💡 Feature request

Feature Name

Create daff-map-get function

The Desired Behavior

daff-map-get function to match the sass map get function, with the addition of throwing an error if key does not exist.

User should retrieve it from @daffodil/design/scss/utilities

Example usage:

@use '@daffodil/design/scss/utilities';

@mixin custom-theme($theme) {
	$base: utilities.daff-map-get($theme, core, base);
}

This will replace the daff-map-deep-get function

Your Use Case

Prior Work

Environment


Daffodil version: X.Y.Z
Angular version: X.Y.Z 

 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@xelaint xelaint added feat a new feature, enhancement, or improvement package: design @daffodil/design labels Oct 22, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone Oct 22, 2024
@gracetxgao gracetxgao linked a pull request Dec 10, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat a new feature, enhancement, or improvement package: design @daffodil/design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants