-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Normalize input interfaces and attributes for design components #763
Labels
feat
a new feature, enhancement, or improvement
p1
critical priority
package: design
@daffodil/design
Milestone
Comments
xelaint
added
feat
a new feature, enhancement, or improvement
package: design
@daffodil/design
labels
Apr 3, 2020
xelaint
changed the title
[FEAT] Refine attribute names for component input variants.
[FEAT] Refine attribute names for component input properties.
Apr 3, 2020
xelaint
changed the title
[FEAT] Refine attribute names for component input properties.
[FEAT] Normalize input interfaces and attributes for design components
Apr 8, 2020
This was referenced Apr 8, 2020
3 tasks
3 tasks
3 tasks
This was referenced Feb 16, 2021
This was referenced Feb 25, 2021
TODO: Document all the interfaces in design components and see which ones need to be created or implement existing interfaces |
@damienwebdev the list in the original issue is correct. DaffOpenable and DaffSelectable are the only properties remaining in design that should be created into interfaces. |
This was referenced Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feat
a new feature, enhancement, or improvement
p1
critical priority
package: design
@daffodil/design
💡 Feature request
Feature Name
Normalize input interfaces and attributes for design components.
The Desired Behavior
Create a list of input interfaces and attributes that will be used across the board in @daffodil/design.
Properties to AVOID (too similar to CSS properties):
Exceptions:
Known Valid Properties:
opened: boolean;
fullscreen: boolean;
size: xs | sm | md | lg | xl
Size (global interface):
Not all sizes need to be exported and used.
Global Interfaces to Create
size
skeleton: boolean;
|DaffSkeletonble
mutating: boolean;
|DaffMutable
DaffCompactable
DaffOpenable
DaffSelectable
Disablable
andFocusable
interfaces fordaff-form-field
Card Types
daff-card
daff-raised-card
daff-stroked-card
Link Set
Feature
Need to Deprecate
center
type? Fixed with textAlignment (#1502)inline-block
update to hero/callout did not work.Your Use Case
As a developer, I'd like to maintain consistency in defining input interfaces and attributes throughout the design package.
Prior Work
Environment
The text was updated successfully, but these errors were encountered: