Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tinyssh-convert usage error #10

Closed
jennydaman opened this issue Oct 24, 2021 · 13 comments · Fixed by #11
Closed

tinyssh-convert usage error #10

jennydaman opened this issue Oct 24, 2021 · 13 comments · Fixed by #11

Comments

@jennydaman
Copy link
Contributor

The CLI for tinyssh-convert was (recently?) changed. Currently, trying to use this package causes:

  -> Running build hook: [tinyssh]
tinyssh-convert: usage: tinyssh-convert out-tinysshkeydir < in-opensshfile

tinyssh-convert -f $osshed25519 -d $destdir

@bf
Copy link

bf commented Nov 5, 2021

@grazzolini can you please merge this? Thank you very much.

@saidie
Copy link

saidie commented Mar 2, 2022

👍
The patch works like a charm

@skaldesh
Copy link

skaldesh commented Mar 9, 2022

ping

@cmm1107
Copy link

cmm1107 commented Mar 10, 2022

I tried the patch but the hook still doesn't appear to add the root_key.
forum post - https://bbs.archlinux.org/viewtopic.php?pid=2026202

@skaldesh
Copy link

skaldesh commented Mar 10, 2022

@cmm1107 If you have run mkinitcpio -P once already, the directory /etc/tinyssh/sshkeydir probably already exists. The script then does not work correctly. Delete the directory and try again, you should then see a message that the OpenSSH keys have been successfully converted.

@cmm1107
Copy link

cmm1107 commented Mar 10, 2022

@cmm1107 If you have run mkinitcpio -P once already, the directory /etc/tinyssh/sshkeydir probably already exists. The script then does not work correctly. Delete the directory and try again, you should then see a message that the OpenSSH keys have been successfully converted.

Thanks @skaldesh did a fresh install with the patch and saw key being added during mkinitcpio.

@decaby7e
Copy link

This is still broken on Arch for me as of today. Applying the patch posted above fixed the issue, but it would be nice if @grazzolini could merge this...

I replaced the check in copy_openssh_keys() for a cleaner install process:

if [ -d $destdir -a -x /usr/bin/tinyssh-convert ]; then
      rmdir $destdir
  fi

@AlbertoBoldrini
Copy link

@grazzolini can you please merge please?

@decaby7e
Copy link

decaby7e commented Jul 5, 2022

Created an issue on the Arch bug tracker to attempt to fork this repo and take ownership of the package, as it seems to have been abandoned.

https://bugs.archlinux.org/task/74522?project=1&opened=37246

@goekce
Copy link

goekce commented Aug 18, 2022

mkinitcpio-systemd-tool seems to be an alternative.

@Joseph-DiGiovanni
Copy link

@grazzolini I understand you no longer use tinyssh as per your comment on the archlinux bug tracker, but how hard is it to review and merge a 6 line PR? Certainly not over 3 years, and likely less time than it took you to write that comment.

@bf
Copy link

bf commented Feb 23, 2024

@Joseph-DiGiovanni instead of being negative here why don't we just fork it, merge it, package it, publish it, and maintain it in the future.

@Joseph-DiGiovanni
Copy link

@bf I can do both. I'll add it to the list of things everyone involved has had to waste their time and effort on so he could avoid a few clicks:

  • Submitting a bug on the arch bug tracker
  • Having to add a note of this issue to the arch wiki
  • Everyone who needs to use this package having to update the script themselves
  • Making a fork
  • Merging the PR
  • Getting the authors attention to update the package since he's also the official package maintainer

If @grazzolini reads this you may update the upstream URL to my fork. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants