Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 11 support #148

Closed
dhernando opened this issue Jan 13, 2021 · 12 comments
Closed

Angular 11 support #148

dhernando opened this issue Jan 13, 2021 · 12 comments

Comments

@dhernando
Copy link

Any plans of upgrading the plugin to support Angular 11?

@erikramalho
Copy link

Please, suport it! ❤️

@NateRadebaugh
Copy link

Is there something unique to this implementation that requires angular 10.x?

@alongouldman
Copy link

did someone find any workarounds for this issue?

@plamendp
Copy link

plamendp commented Mar 5, 2021

I've just upgraded Angular from 10 to 11.

"npm install" warns me about the broken requirement, but application works nonetheless (keep alive, pings, etc.).

However, yes, would be nice to have dependency updated.

@NateRadebaugh
Copy link

Is this PR enough to resolve this, or is there more work needed? What can we do to get this completed?
#151

@pmcelreavy
Copy link

The project is looking for a maintainer though. I don't know if the current maintainer has much time to even look at the issues.

@NehaTawar
Copy link

NehaTawar commented Jul 8, 2021

Any updates on upgrading the plugin to support latest Angular 12+?
Getting a error of incompatibility with @angular/common. Have to force install the node_modules.

@NateRadebaugh
Copy link

Seems these issues are ignored. After all this time may make sense to fork this repo and release a separate package.

@erikramalho
Copy link

Hey @NateRadebaugh why don’t you fork it and we all can use your fork? You’re right. This repo seems to be dead at all… we all coul maintain it

@grbsk
Copy link
Owner

grbsk commented Jul 8, 2021

#97 is a pinned topic about needing a new maintainer if you want to get involved. I'll also accept a pull request for Angular 11 support. Someone is working on 12.

@NateRadebaugh
Copy link

NateRadebaugh commented Jul 8, 2021

Thanks @moribvndvs we'll track next steps with @worksoncloud since it looks like he's the newly appointed maintainer.

[Edit] looks like the PR with support for Angular 12 is here: #151

@grbsk
Copy link
Owner

grbsk commented Jul 18, 2021

#151 has been merged and this has all been released as 11.0.3

@grbsk grbsk closed this as completed Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants