Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After an PHP analysis, no ecocode code smells appears in my Sonar project. #71

Closed
guiyom19 opened this issue Mar 7, 2023 · 6 comments
Closed
Assignees
Labels
php __PRIO_HIGH__ 💉 bug Something isn't working

Comments

@guiyom19
Copy link

guiyom19 commented Mar 7, 2023

First of all, thank you for your work!

After an analysis, no ecocode code smells appears in my Sonar project :

I added the ecocode-php-plugin-0.2.2.jar in the extensions/plugins directory.
All rules appears in my quality profiles and I've activate them.

image

My project use the good quality PHP ecoCode profile where I use those rules.

But when I add some dirty code on my Symfony project ie :
image
Only basic sonar way code smell is detected.

Do I missed something in my Sonar configuration?

Thanks a lot for your answer

Software Versions

  • SonarQube Version: 9.4
  • Plugin Version: 0.2.2

Guillaume

@guiyom19 guiyom19 added the 💉 bug Something isn't working label Mar 7, 2023
@dedece35
Copy link
Member

dedece35 commented Mar 7, 2023

Hi @guiyom19,

thank you for your issue.

The best thing to do to check this issue is to create a test project like mentionned here #65 (in progress for java language).
I will work on it soon unless if you want to create it ;p

@dedece35 dedece35 changed the title After an analysis, no ecocode code smells appears in my Sonar project. After an PHP analysis, no ecocode code smells appears in my Sonar project. Mar 14, 2023
@dedece35
Copy link
Member

I think is the same problem as #64 for python plugin (correction with PR #77)
I will work on it soon.

@dedece35
Copy link
Member

dedece35 commented Mar 17, 2023

for information :

@dedece35 dedece35 self-assigned this Mar 17, 2023
@dedece35
Copy link
Member

Hi @guiyom19,
all is ok now.
please, test it with out new real test project above.

@guiyom19
Copy link
Author

guiyom19 commented Mar 27, 2023

Thank you @dedece35 for your work
I got the last ecocode-php-plugin-1.0.0 but so far I have this error when I start Sonar Server :
The plugin 'php' is in version 3.23.1.8766 whereas the plugin 'ecocodephp' requires a least a version 3.25.0.9077.
I tried to upgrade Sonar Server to 9.9 but I got a new error that is apparently related to my Java version:

Erreur : LinkageError lors du chargement de la classe principale org.sonar.application.App
        java.lang.UnsupportedClassVersionError: org/sonar/application/App has been compiled by a more recent version of the Java Runtime (class file version 61.0), this version of the Java Runtime only recognizes class file versions up to 55.0

I'll keep trying and let you know!

@guiyom19
Copy link
Author

Hi @dedece35,
I finally got it work with your new 1.0.0 php plugin.
Many ecocode issues pop as bugs in my projects
image
Many thanks again and good luck for the next steps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
php __PRIO_HIGH__ 💉 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants