Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] stopEventPropagationAfterIgnoring: false leads to Ctrl+E only being matched when pressed in reverse (E+Ctrl) #260

Open
Nantris opened this issue Dec 2, 2019 · 1 comment

Comments

@Nantris
Copy link

Nantris commented Dec 2, 2019

Describe the bug
E+Ctrl matches, but Ctrl+E does not match - only with stopEventPropagationAfterIgnoring: false

How are you using react hotkeys components? (HotKeys, GlobalHotKeys, IgnoreKeys etc)
<GlobalHotKeys />

Expected behavior
Ctrl+E should be caught and fire the handler. Instead, only the following are caught:

  • E+Ctrl

or

  1. Press and hold Ctrl+E
  2. Release E
  3. Press E again

Platform (please complete the following information):

  • Version of react-hotkeys 2.0.0
  • Browser [e.g. chrome, safari] Electron@6.0.12
  • OS: [e.g. iOS] Windows 7

Are you willing and able to create a PR request to fix this issue?

No

What Configuration options are you using?

  configure({
    ignoreEventsCondition: evt => false,
    stopEventPropagationAfterIgnoring: false,
  });
@greena13
Copy link
Owner

greena13 commented Jan 1, 2020

Thanks for posting your issue.

Unfortunately I do not have the time to actively work on this package, but I am seeking other active maintainers. If you are willing to create a pull request or help out, that would be an excellent way of moving this forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants